[
https://issues.apache.org/jira/browse/HDFS-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330398#comment-17330398
]
Viraj Jasani edited comment on HDFS-15982 at 4/23/21, 11:39 AM:
----------------------------------------------------------------
{quote}Let's rename the JIRA subject and also PR by replacing "Web UI" with
"HTTP API". HDFS "Web UI" is usually about the web portal that one can browse
for information purpose. This JIRA is to change the "RESTful HTTP API", not
about the Web UI.
{quote}
Thanks [~liuml07], yes the core changes are at API level and hence I have
updated Jira as well as PR titles. However, in the recent revision, I have
added "skipTrash" option in API, which is accessible through UI. Please find
attached screenshots.
{quote}My only concern about this is that, the "Trash" concept is not a part of
the FileSystem DELETE API. Changing this behavior may break existing
applications that assumes storage will be released.
{quote}
I understand and hence there is no attempt to change FileSystem DELETE API
itself, rather the changes are limited to NamenodeWebHdfsMethods endpoint only.
{quote}It seems counter-intuitive that one can skipTrash from command line but
can not using WebHDFS. Since keeping data in Trash for a while is usually a
good idea, I think I'm fine with this feature proposal. Ideally we can expose
-skipTrash parameter so users can choose.
{quote}
Thanks for this advice. Updated PR revision has this change.
{quote}When I explore I found HDFS-14320 is all about the same idea and similar
implementation. Do you guys want to post there and try with a collaboration to
get this in? I did not look into that closely.
{quote}
Apologies, I was not aware of existing Jira already. Thanks for pointing this
out. I have commented over this Jira as well. Since that Jira's last patch
revision was more than 2 yr old, I am not sure if the patch is upto date or we
will get active response from there.
Please find attached screenshots and review
[PR|https://github.com/apache/hadoop/pull/2927] as per your convenience. Thanks.
was (Author: vjasani):
{quote}Let's rename the JIRA subject and also PR by replacing "Web UI" with
"HTTP API". HDFS "Web UI" is usually about the web portal that one can browse
for information purpose. This JIRA is to change the "RESTful HTTP API", not
about the Web UI.
{quote}
Thanks [~liuml07], yes the core changes are at API level and hence I have
updated Jira as well as PR titles. However, in the recent revision, I have
added "skipTrash" option in API, which can be accessed through UI. Please find
attached screenshots.
{quote}My only concern about this is that, the "Trash" concept is not a part of
the FileSystem DELETE API. Changing this behavior may break existing
applications that assumes storage will be released.
{quote}
I understand and hence there is no attempt to change FileSystem DELETE API
itself, rather the changes are limited to NamenodeWebHdfsMethods endpoint only.
{quote}It seems counter-intuitive that one can skipTrash from command line but
can not using WebHDFS. Since keeping data in Trash for a while is usually a
good idea, I think I'm fine with this feature proposal. Ideally we can expose
-skipTrash parameter so users can choose.
{quote}
Thanks for this advice. Updated PR revision has this change.
{quote}When I explore I found HDFS-14320 is all about the same idea and similar
implementation. Do you guys want to post there and try with a collaboration to
get this in? I did not look into that closely.
{quote}
Apologies, I was not aware of existing Jira already. Thanks for pointing this
out. I have commented over this Jira as well. Since that Jira's last patch
revision was more than 2 yr old, I am not sure if the patch is upto date or we
will get active response from there.
Please find attached screenshots and review as per your convenience. Thanks.
> Deleted data using HTTP API should be saved to the trash
> --------------------------------------------------------
>
> Key: HDFS-15982
> URL: https://issues.apache.org/jira/browse/HDFS-15982
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: hdfs
> Reporter: Bhavik Patel
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Attachments: Screenshot 2021-04-23 at 4.19.42 PM.png, Screenshot
> 2021-04-23 at 4.36.57 PM.png
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> If we delete the data from the Web UI then it should be first moved to
> configured/default Trash directory and after the trash interval time, it
> should be removed. currently, data directly removed from the system[This
> behavior should be the same as CLI cmd]
> This can be helpful when the user accidentally deletes data from the Web UI.
> Similarly we should provide "Skip Trash" option in HTTP API as well which
> should be accessible through Web UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
