[ https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335210#comment-17335210 ]
lei w commented on HDFS-16003: ------------------------------ In the actual production environment, the log level is generally info. We first judged the log level will save the time of traversing the collection. If the log level is debug, then we can traverse the collection and print the information. So we will not loss trace information about some specific blocks. > ProcessReport print invalidatedBlocks should judge debug level at first > ----------------------------------------------------------------------- > > Key: HDFS-16003 > URL: https://issues.apache.org/jira/browse/HDFS-16003 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namanode > Affects Versions: 3.3.0 > Reporter: lei w > Priority: Minor > Attachments: HDFS-16003.patch > > > In BlockManager#processReport( ) method, we will print invalidated blocks if > log level is debug。We always traverse this invalidatedBlocks list without > considering the log level。I suggest to give priority to the log level before > printing, which can save the time of traversal if log level is info. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org