[
https://issues.apache.org/jira/browse/HDFS-15934?focusedWorklogId=592667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592667
]
ASF GitHub Bot logged work on HDFS-15934:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/May/21 11:07
Start Date: 04/May/21 11:07
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2833:
URL: https://github.com/apache/hadoop/pull/2833#discussion_r625692545
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
##########
@@ -315,6 +316,41 @@ public DirectoryScanner(FsDatasetSpi<?> dataset,
Configuration conf) {
masterThread =
new ScheduledThreadPoolExecutor(1, new Daemon.DaemonFactory());
+
+ int reconcileBatchSize =
+ conf.getInt(DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_SIZE,
+ DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_SIZE_DEFAULT);
+
+ if (reconcileBatchSize < 0) {
Review comment:
change it to <=0
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
##########
@@ -315,6 +316,41 @@ public DirectoryScanner(FsDatasetSpi<?> dataset,
Configuration conf) {
masterThread =
new ScheduledThreadPoolExecutor(1, new Daemon.DaemonFactory());
+
+ int reconcileBatchSize =
+ conf.getInt(DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_SIZE,
+ DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_SIZE_DEFAULT);
+
+ if (reconcileBatchSize < 0) {
+ LOG.warn("Invalid value configured for " +
+ "dfs.datanode.reconcile.blocks.batch.size, " +
+ "should be greater than 0, Using default.");
+ reconcileBatchSize =
+ DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_SIZE_DEFAULT;
+ }
+
+ reconcileBlocksBatchSize = reconcileBatchSize;
+
+ long reconcileBatchInterval =
+ conf.getTimeDuration(DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_INTERVAL,
+ DFSConfigKeys.
+ DFS_DATANODE_RECONCILE_BLOCKS_BATCH_INTERVAL_DEFAULT,
+ TimeUnit.MILLISECONDS);
+
+ if (reconcileBatchInterval < 0) {
Review comment:
change it to <=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 592667)
Time Spent: 2h 20m (was: 2h 10m)
> Make DirectoryScanner reconcile blocks batch size and interval between batch
> configurable.
> ------------------------------------------------------------------------------------------
>
> Key: HDFS-15934
> URL: https://issues.apache.org/jira/browse/HDFS-15934
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Qi Zhu
> Assignee: Qi Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> HDFS-14476 Make this batch to avoid lock too much time, but different cluster
> has different demand, we should make batch size and batch interval
> configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
