[ 
https://issues.apache.org/jira/browse/HDFS-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HDFS-2654:
-----------------------------

         Description: The BlockReaderLocal code paths are easier to understand 
(especially true on branch-1 where BlockReaderLocal inherits code from 
BlockerReader and FSInputChecker) if the local and remote block reader 
implementations are independent, and they're not really sharing much code 
anyway. If for some reason they start to share significant code we can make the 
BlockReader interface an abstract class.  (was: The BlockReaderLocal code paths 
are easier to understand (especially true on branch-1 where BlockReaderLocal 
inherits code from BlockerReader and FSInputChecker) if the local and remote 
block reader implementations are independent, and they're not really sharing 
much code anyway. If for some reason they start to share sifnificant code we 
can make the BlockReader interface an abstract class.)
    Target Version/s: 0.23.1, 1.1.0  (was: 1.1.0, 0.23.1)
    
> Make BlockReaderLocal not extend RemoteBlockReader2
> ---------------------------------------------------
>
>                 Key: HDFS-2654
>                 URL: https://issues.apache.org/jira/browse/HDFS-2654
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1, 1.0.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-2654-1.patch, hdfs-2654-2.patch, hdfs-2654-2.patch, 
> hdfs-2654-2.patch, hdfs-2654-3.patch, hdfs-2654-b1-1.patch, 
> hdfs-2654-b1-2.patch, hdfs-2654-b1-3.patch, hdfs-2654-b1-4-fix.patch, 
> hdfs-2654-b1-4.patch
>
>
> The BlockReaderLocal code paths are easier to understand (especially true on 
> branch-1 where BlockReaderLocal inherits code from BlockerReader and 
> FSInputChecker) if the local and remote block reader implementations are 
> independent, and they're not really sharing much code anyway. If for some 
> reason they start to share significant code we can make the BlockReader 
> interface an abstract class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to