[ https://issues.apache.org/jira/browse/HDFS-16031?focusedWorklogId=600982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600982 ]
ASF GitHub Bot logged work on HDFS-16031: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/May/21 22:45 Start Date: 23/May/21 22:45 Worklog Time Spent: 10m Work Description: Nargeshdb commented on pull request #3027: URL: https://github.com/apache/hadoop/pull/3027#issuecomment-846635685 > Thanks for the patch. @aajisaka Thanks for the feedback. > We should use try-with-resources to close the resources. https://github.com/apache/hadoop/pull/3027/commits/d0d81d605cadde6dd7ecc0813e2a929e31d22f97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 600982) Time Spent: 0.5h (was: 20m) > Possible Resource Leak in > org.apache.hadoop.hdfs.server.aliasmap#InMemoryAliasMap > --------------------------------------------------------------------------------- > > Key: HDFS-16031 > URL: https://issues.apache.org/jira/browse/HDFS-16031 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Narges Shadab > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > We notice a possible resource leak in > [getCompressedAliasMap|https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/aliasmap/InMemoryAliasMap.java#L320]. > If {{finish()}} at line 334 throws an IOException, then {{tOut, gzOut}} and > {{bOut}} remain open since the exception isn't caught locally, and there is > no way for any caller to close them. > I've submitted a pull request to fix it. > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org