[ 
https://issues.apache.org/jira/browse/HDFS-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177371#comment-13177371
 ] 

Todd Lipcon commented on HDFS-2720:
-----------------------------------

Small nits:

{code}
+      // Now format 1st NN and copy the storage dirs to remaining all.
{code}
"to remaining all" seems like a typo. "copy the storage directory from that 
node to the others." would be better. Also I think it's easier to read "first" 
than "1st"
----

{code}
+      //Start all Namenodes
{code}
add space after {{//}}

----

- The change to remove setRpcEngine looks unrelated - that should get cleaned 
up in trunk so it doesn't present a merge issue in the branch.
                
> HA : TestStandbyIsHot is failing while copying in_use.lock file from NN1 
> nameSpaceDirs to NN2 nameSpaceDirs 
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2720
>                 URL: https://issues.apache.org/jira/browse/HDFS-2720
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha, test
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2720.patch
>
>
> To maintain the clusterID same , we are copying the namespaceDirs from 1st NN 
> to other NNs.
> While copying this files, in_use.lock file may not allow to copy in all the 
> OSs since it has aquired the lock on it. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to