[
https://issues.apache.org/jira/browse/HDFS-16048?focusedWorklogId=604892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604892
]
ASF GitHub Bot logged work on HDFS-16048:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/21 01:56
Start Date: 02/Jun/21 01:56
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3062:
URL: https://github.com/apache/hadoop/pull/3062#discussion_r643597149
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterNetworkTopologyServlet.java
##########
@@ -0,0 +1,187 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdfs.server.federation.router;
+
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.JsonGenerator;
+import org.apache.hadoop.hdfs.protocol.DatanodeInfo;
+import org.apache.hadoop.hdfs.protocol.HdfsConstants;
+import org.apache.hadoop.net.NetUtils;
+import org.apache.hadoop.net.Node;
+import
org.apache.hadoop.thirdparty.com.google.common.annotations.VisibleForTesting;
+import org.apache.hadoop.util.StringUtils;
+
+import javax.servlet.ServletContext;
+import javax.servlet.http.HttpServlet;
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+import javax.ws.rs.core.HttpHeaders;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.TreeSet;
+
+/**
+ * A servlet to print out the network topology from router.
+ */
+public class RouterNetworkTopologyServlet extends HttpServlet {
+
+ public static final String SERVLET_NAME = "topology";
+ public static final String PATH_SPEC = "/topology";
+
+ protected static final String FORMAT_JSON = "json";
+ protected static final String FORMAT_TEXT = "text";
+
+ @Override
+ public void doGet(HttpServletRequest request, HttpServletResponse response)
+ throws IOException {
+ final ServletContext context = getServletContext();
+
+ String format = parseAcceptHeader(request);
+ if (FORMAT_TEXT.equals(format)) {
+ response.setContentType("text/plain; charset=UTF-8");
+ } else if (FORMAT_JSON.equals(format)) {
+ response.setContentType("application/json; charset=UTF-8");
+ }
+
+ Router router = RouterHttpServer.getRouterFromContext(context);
+ DatanodeInfo[] datanodeReport =
+ router.getRpcServer().getDatanodeReport(
+ HdfsConstants.DatanodeReportType.ALL);
+
+ try (PrintStream out = new PrintStream(
+ response.getOutputStream(), false, "UTF-8")) {
+ printTopology(out, datanodeReport, format);
+ } catch (Throwable t) {
+ String errMsg = "Print network topology failed. "
+ + StringUtils.stringifyException(t);
+ response.sendError(HttpServletResponse.SC_GONE, errMsg);
+ throw new IOException(errMsg);
+ } finally {
+ response.getOutputStream().close();
+ }
+ }
+
+ /**
+ * Display each rack and the nodes assigned to that rack, as determined
+ * by the NameNode, in a hierarchical manner. The nodes and racks are
+ * sorted alphabetically.
+ *
+ * @param stream print stream
+ * @param datanodeInfos datanode Infos
+ * @param format the response format
+ */
+ public void printTopology(PrintStream stream, DatanodeInfo[] datanodeInfos,
+ String format) throws IOException, BadFormatException {
+ if (datanodeInfos.length == 0) {
+ stream.print("No DataNodes");
+ return;
+ }
+
+ // Build a map of rack -> nodes
+ Map<String, TreeSet<String>> tree = new HashMap<>();
+ for(Node dni : datanodeInfos) {
+ String location = dni.getNetworkLocation();
+ String name = dni.getName();
+
+ tree.putIfAbsent(location, new TreeSet<>());
+ tree.get(location).add(name);
+ }
+
+ // Sort the racks (and nodes) alphabetically, display in order
+ ArrayList<String> racks = new ArrayList<>(tree.keySet());
+ Collections.sort(racks);
+
+ if (FORMAT_JSON.equals(format)) {
+ printJsonFormat(stream, tree, racks);
+ } else if (FORMAT_TEXT.equals(format)) {
+ printTextFormat(stream, tree, racks);
+ } else {
+ throw new BadFormatException("Bad format: " + format);
+ }
+ }
+
+ private void printJsonFormat(PrintStream stream, Map<String,
+ TreeSet<String>> tree, ArrayList<String> racks) throws IOException {
+ JsonFactory dumpFactory = new JsonFactory();
+ JsonGenerator dumpGenerator = dumpFactory.createGenerator(stream);
+ dumpGenerator.writeStartArray();
+
+ for(String r : racks) {
+ dumpGenerator.writeStartObject();
+ dumpGenerator.writeFieldName(r);
+ TreeSet<String> nodes = tree.get(r);
+ dumpGenerator.writeStartArray();
+
+ for(String n : nodes) {
+ dumpGenerator.writeStartObject();
+ dumpGenerator.writeStringField("ip", n);
+ String hostname = NetUtils.getHostNameOfIP(n);
+ if(hostname != null) {
+ dumpGenerator.writeStringField("hostname", hostname);
+ }
+ dumpGenerator.writeEndObject();
+ }
+ dumpGenerator.writeEndArray();
+ dumpGenerator.writeEndObject();
+ }
+ dumpGenerator.writeEndArray();
+ dumpGenerator.flush();
+
+ if (!dumpGenerator.isClosed()) {
+ dumpGenerator.close();
+ }
+ }
+
+ private void printTextFormat(PrintStream stream, Map<String,
Review comment:
> Can we reuse some of this code from the other PR?
Thanks @goiri for you review, I made some changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 604892)
Time Spent: 1h 20m (was: 1h 10m)
> RBF: Print network topology on the router web
> ---------------------------------------------
>
> Key: HDFS-16048
> URL: https://issues.apache.org/jira/browse/HDFS-16048
> Project: Hadoop HDFS
> Issue Type: Wish
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Attachments: topology-json.jpg, topology-text.jpg
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In order to query the network topology information conveniently, we can print
> it on the router web. It's related to HDFS-15970.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
