[
https://issues.apache.org/jira/browse/HDFS-16042?focusedWorklogId=607107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607107
]
ASF GitHub Bot logged work on HDFS-16042:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/21 14:21
Start Date: 04/Jun/21 14:21
Worklog Time Spent: 10m
Work Description: jbrennan333 commented on pull request #3058:
URL: https://github.com/apache/hadoop/pull/3058#issuecomment-854764625
@amahussein code looks good. As @kihwal said, please take a look at the
unit test failures to see if they are related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 607107)
Time Spent: 50m (was: 40m)
> DatanodeAdminMonitor scan should be delay based
> -----------------------------------------------
>
> Key: HDFS-16042
> URL: https://issues.apache.org/jira/browse/HDFS-16042
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a
> fixed rate, ie. the period is from start1 -> start2.
> {code:java}
> executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs,
> TimeUnit.SECONDS);
> {code}
> According to Java API docs for {{scheduleAtFixedRate}},
> {quote}If any execution of this task takes longer than its period, then
> subsequent executions may start late, but will not concurrently
> execute.{quote}
> It should be a fixed delay so it's end1 -> start1.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
