[ https://issues.apache.org/jira/browse/HDFS-16055?focusedWorklogId=608683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608683 ]
ASF GitHub Bot logged work on HDFS-16055: ----------------------------------------- Author: ASF GitHub Bot Created on: 08/Jun/21 19:17 Start Date: 08/Jun/21 19:17 Worklog Time Spent: 10m Work Description: smengcl commented on pull request #3078: URL: https://github.com/apache/hadoop/pull/3078#issuecomment-857033639 The cause of the UT failure `testRenameDirAndDeleteSnapshot_1` is that features in the stream are returned as **references**. While this is fine for AclFeature or XAttrFeature. A `DirectoryWithQuotaFeature` will get updated when namespace or space usage has changed. Hence the snapshot inode sharing a same `DirectoryWithQuotaFeature` with the original dir inode becomes a problem in this test case where it compares the quota usage before and after NN restart. Updated the patch to create copy of the `DirectoryWithQuotaFeature`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 608683) Time Spent: 40m (was: 0.5h) > Quota is not preserved in snapshot INode > ---------------------------------------- > > Key: HDFS-16055 > URL: https://issues.apache.org/jira/browse/HDFS-16055 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 3.3.0 > Reporter: Siyao Meng > Assignee: Siyao Meng > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Quota feature is not preserved during snapshot creation, this causes > {{INodeDirectory#metadataEquals}} to ALWAYS return true. Therefore, > {{snapshotDiff}} will ALWAYS return the snapshot root as modified, even if > the quota is set before the snapshot creation: > {code:bash} > $ hdfs snapshotDiff /diffTest s0 . > Difference between snapshot s0 and current directory under directory > /diffTest: > M . > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org