[
https://issues.apache.org/jira/browse/HDFS-16065?focusedWorklogId=610758&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610758
]
ASF GitHub Bot logged work on HDFS-16065:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 16:26
Start Date: 14/Jun/21 16:26
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3100:
URL: https://github.com/apache/hadoop/pull/3100#discussion_r651097583
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -471,6 +471,9 @@ private Object invokeMethod(
if (this.rpcMonitor != null) {
this.rpcMonitor.proxyOpComplete(true);
}
+ if (this.router.getRouterMetrics() != null) {
+ this.router.getRouterMetrics().incInvokedMethod(method);
Review comment:
You are adding all these metrics raw to RouterMetrics.
I'm wondering if we should have something that refers to this being metrics
for the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 610758)
Time Spent: 1h 10m (was: 1h)
> RBF: Add metrics to record Router's operations
> ----------------------------------------------
>
> Key: HDFS-16065
> URL: https://issues.apache.org/jira/browse/HDFS-16065
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: Janus Chow
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, Router's operations are not well recorded. It would be good to
> have a similar metrics as "Hadoop:service=NameNode,name=NameNodeActivity" for
> NameNode, which shows the count for each operations.
> Besides, some operations are invoked concurrently in Routers, know the counts
> for concurrent operations would help us better knowing about the cluster's
> state.
> This ticket is to add normal operation metrics and concurrent operation
> metrics for Router.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
