[
https://issues.apache.org/jira/browse/HDFS-16016?focusedWorklogId=610846&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-610846
]
ASF GitHub Bot logged work on HDFS-16016:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 19:03
Start Date: 14/Jun/21 19:03
Worklog Time Spent: 10m
Work Description: smengcl commented on a change in pull request #2998:
URL: https://github.com/apache/hadoop/pull/2998#discussion_r651200801
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeReport.java
##########
@@ -172,8 +172,20 @@ public void testDatanodeReportMissingBlock() throws
Exception {
// all bad datanodes
}
cluster.triggerHeartbeats(); // IBR delete ack
- lb = fs.getClient().getLocatedBlocks(p.toString(), 0).get(0);
- assertEquals(0, lb.getLocations().length);
+ int retries = 0;
+ while (true) {
+ lb = fs.getClient().getLocatedBlocks(p.toString(), 0).get(0);
+ if (0 != lb.getLocations().length) {
+ retries++;
+ if (retries > 7) {
+ Assert.fail("getLocatedBlocks failed after 7 retries");
+ break;
Review comment:
```suggestion
```
nit: `break` is unnecessary now. `Assert.fail` will throw `AssertionError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 610846)
Time Spent: 4h 50m (was: 4h 40m)
> BPServiceActor add a new thread to handle IBR
> ---------------------------------------------
>
> Key: HDFS-16016
> URL: https://issues.apache.org/jira/browse/HDFS-16016
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: Viraj Jasani
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Now BPServiceActor#offerService() is doing many things, FBR, IBR, heartbeat.
> We can handle IBR independently to improve the performance of heartbeat and
> FBR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
