[ 
https://issues.apache.org/jira/browse/HDFS-16075?focusedWorklogId=612142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612142
 ]

ASF GitHub Bot logged work on HDFS-16075:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jun/21 21:25
            Start Date: 18/Jun/21 21:25
    Worklog Time Spent: 10m 
      Work Description: virajjasani edited a comment on pull request #3115:
URL: https://github.com/apache/hadoop/pull/3115#issuecomment-864127746


   > @virajjasani Thanks.
   > It seems that the following source files have the same problem.
   > 
   > > 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskCompletionEvent.java
   > > 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/TaskCompletionEvent.java
   > > 
hadoop-tools/hadoop-resourceestimator/src/main/java/org/apache/hadoop/resourceestimator/common/config/ResourceEstimatorUtil.java
   > > 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CachedBlock.java
   
   Thanks for pointing this out @ferhui. IIUC, `new TaskCompletionEvent[0]` is 
being used at few places and we can replace them, however I could not see issue 
with `ResourceEstimatorUtil` and `CachedBlock`. Could you please help me 
understand? Thanks
   
   Edit: Is it good to track `TaskCompletionEvent` changes in separate 
MapReduce Jira?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 612142)
    Time Spent: 50m  (was: 40m)

> Use empty array constants present in StorageType and DatanodeInfo to avoid 
> creating redundant objects
> -----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16075
>                 URL: https://issues.apache.org/jira/browse/HDFS-16075
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> StorageType and DatanodeInfo already provides empty array constants. We 
> should use them where possible in order to avoid creating unnecessary new 
> empty array objects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to