[ https://issues.apache.org/jira/browse/HDFS-16088?focusedWorklogId=618312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-618312 ]
ASF GitHub Bot logged work on HDFS-16088: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Jul/21 02:21 Start Date: 03/Jul/21 02:21 Worklog Time Spent: 10m Work Description: tomscut commented on pull request #3140: URL: https://github.com/apache/hadoop/pull/3140#issuecomment-873329818 > @tomscut Thanks for contribution. > I see that getLiveDatanodeStorageReport and getBlocks mostly have the same code. Better to extract them into a new method and it will be more clean. Hi @ferhui , I fixed it. Could you please take a look when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 618312) Time Spent: 1.5h (was: 1h 20m) > Standby NameNode process getLiveDatanodeStorageReport request to reduce > Active load > ----------------------------------------------------------------------------------- > > Key: HDFS-16088 > URL: https://issues.apache.org/jira/browse/HDFS-16088 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: tomscut > Assignee: tomscut > Priority: Minor > Labels: pull-request-available > Attachments: standyby-ipcserver.jpg > > Time Spent: 1.5h > Remaining Estimate: 0h > > As with HDFS-13183, NameNodeConnector#getLiveDatanodeStorageReport() can also > request to SNN to reduce the ANN load. > There are two points that need to be mentioned: > 1. FSNamesystem#getLiveDatanodeStorageReport() is > OperationCategory.UNCHECKED, so we can access SNN directly. > 2. We can share the same UT(testBalancerRequestSBNWithHA) with > NameNodeConnector#getBlocks(). -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org