[
https://issues.apache.org/jira/browse/HDFS-16042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17381509#comment-17381509
]
Ahmed Hussein commented on HDFS-16042:
--------------------------------------
I have uploaded patches for 2.10, 3.2, and 3.3 and posted the conflicts (if
any) in the above comments.
The yetus did not trigger since yesterday, but compiled the patches locally
anyway
(perhaps the jira-precommits won't run anymore following the discussion in the
community and HADOOP-17798).
[~Jim_Brennan], can you please merge those patches into their respective
branches?
> DatanodeAdminMonitor scan should be delay based
> -----------------------------------------------
>
> Key: HDFS-16042
> URL: https://issues.apache.org/jira/browse/HDFS-16042
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: HDFS-16042-branch-2.10.001.patch,
> HDFS-16042-branch-3.2.001.patch, HDFS-16042-branch-3.3.001.patch
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In {{DatanodeAdminManager.activate()}}, the Monitor task is scheduled with a
> fixed rate, ie. the period is from start1 -> start2.
> {code:java}
> executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs,
> TimeUnit.SECONDS);
> {code}
> According to Java API docs for {{scheduleAtFixedRate}},
> {quote}If any execution of this task takes longer than its period, then
> subsequent executions may start late, but will not concurrently
> execute.{quote}
> It should be a fixed delay so it's end1 -> start1.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
