[
https://issues.apache.org/jira/browse/HDFS-16138?focusedWorklogId=628870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628870
]
ASF GitHub Bot logged work on HDFS-16138:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/21 05:01
Start Date: 28/Jul/21 05:01
Worklog Time Spent: 10m
Work Description: jojochuang commented on a change in pull request #3244:
URL: https://github.com/apache/hadoop/pull/3244#discussion_r677973915
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
##########
@@ -5190,7 +5191,7 @@ public void run() {
processQueue();
} catch (Throwable t) {
ExitUtil.terminate(1,
- getName() + " encountered fatal exception: " + t);
+ getName() + " encountered fatal exception: " +
ExceptionUtils.getStackTrace(t));
Review comment:
looking at other usage in the Hadoop codebase, it seems to me a better
way to print stack trace is to use the logger before exiting through
ExitUtil.terminate().
https://github.com/apache/hadoop/blob/d0dcfc405c624f73ed1af9527bbf456a10337a6d/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceMaster.java#L353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 628870)
Time Spent: 0.5h (was: 20m)
> BlockReportProcessingThread exit doesnt print the acutal stack
> --------------------------------------------------------------
>
> Key: HDFS-16138
> URL: https://issues.apache.org/jira/browse/HDFS-16138
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Renukaprasad C
> Assignee: Renukaprasad C
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> BlockReportProcessingThread thread may gets exited with multiple reasons, but
> the current logging prints only the exception message with different stack
> which is difficult to debug the issue.
>
> Existing logging:
> 2021-07-20 10:20:23,104 [Block report processor] INFO util.ExitUtil
> (ExitUtil.java:terminate(210)) - Exiting with status 1: Block report
> processor encountered fatal exception: java.lang.AssertionError
> 2021-07-20 10:20:23,104 [Block report processor] ERROR util.ExitUtil
> (ExitUtil.java:terminate(213)) - Terminate called
> 1: Block report processor encountered fatal exception:
> java.lang.AssertionError
> at
> org.apache.hadoop.util.ExitUtil.terminate(ExitUtil.java:304)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$BlockReportProcessingThread.run(BlockManager.java:5315)
> Exception in thread "Block report processor" 1: Block report processor
> encountered fatal exception: java.lang.AssertionError
> at
> org.apache.hadoop.util.ExitUtil.terminate(ExitUtil.java:304)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$BlockReportProcessingThread.run(BlockManager.java:5315)
>
> Actual issue found at:
> 2021-07-20 10:20:23,101 [Block report processor] ERROR
> blockmanagement.BlockManager (BlockManager.java:run(5314)) -
> java.lang.AssertionError
> java.lang.AssertionError
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addStoredBlock(BlockManager.java:3480)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:4280)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addBlock(BlockManager.java:4202)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:4338)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:4305)
> at
> org.apache.hadoop.hdfs.server.namenode.FSNamesystem.processIncrementalBlockReport(FSNamesystem.java:4853)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer$2.run(NameNodeRpcServer.java:1657)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$BlockReportProcessingThread.processQueue(BlockManager.java:5334)
> at
> org.apache.hadoop.hdfs.server.blockmanagement.BlockManager$BlockReportProcessingThread.run(BlockManager.java:5312)
>
> This issue found while working on FGL branch. But, same issue can happen in
> Trunk also in any error scenario.
>
> [~hemanthboyina] [~hexiaoqiao]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
