[ https://issues.apache.org/jira/browse/HDFS-16143?focusedWorklogId=640433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640433 ]
ASF GitHub Bot logged work on HDFS-16143: ----------------------------------------- Author: ASF GitHub Bot Created on: 21/Aug/21 07:50 Start Date: 21/Aug/21 07:50 Worklog Time Spent: 10m Work Description: liuml07 commented on a change in pull request #3235: URL: https://github.com/apache/hadoop/pull/3235#discussion_r693319627 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java ########## @@ -429,19 +431,31 @@ public void testStandbyTriggersLogRollsWhenTailInProgressEdits() waitForStandbyToCatchUpWithInProgressEdits(standby, activeTxId, standbyCatchupWaitTime); + long curTime = standby.getNamesystem().getEditLogTailer().getTimer() + .monotonicNow(); + long inSufficientTimeForLogRoll = + TimeUnit.SECONDS.toMillis(logRollPeriod / 3); Review comment: A few places changing this `logRollPeriod` from seconds to milliseconds. It seems clearer to jut rename it to `logRollPeriodMs` and use values in milliseconds. ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java ########## @@ -488,4 +509,19 @@ private static MiniDFSCluster createMiniDFSCluster(Configuration conf, .build(); return cluster; } + + private static final class TestTimer extends Timer { Review comment: I think the common faker timer would be better if we create a new public constructor? Using `advance` would be more clearer when reading. ``` FakeTimer fakeTimer = new FakeTimer(standby.getNamesystem().getEditLogTailer().getTimer().monotonicNow()); standby.getNamesystem().getEditLogTailer().setTimerForTest(fakerTimer); ... fakeTimer.advance(inSufficientTimeForLogRoll); try { checkForLogRoll(active, origTxId, noLogRollWaitTime); fail("Expected to timeout"); } .... fakeTimer.advance(sufficientTimeForLogRoll); checkForLogRoll(active, origTxId, logRollWaitTime); ``` ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestEditLogTailer.java ########## @@ -429,19 +431,31 @@ public void testStandbyTriggersLogRollsWhenTailInProgressEdits() waitForStandbyToCatchUpWithInProgressEdits(standby, activeTxId, standbyCatchupWaitTime); + long curTime = standby.getNamesystem().getEditLogTailer().getTimer() + .monotonicNow(); + long inSufficientTimeForLogRoll = + TimeUnit.SECONDS.toMillis(logRollPeriod / 3); + TestTimer testTimer = new TestTimer(curTime + inSufficientTimeForLogRoll); + standby.getNamesystem().getEditLogTailer().setTimerForTest(testTimer); + for (int i = DIRS_TO_MAKE / 2; i < DIRS_TO_MAKE; i++) { NameNodeAdapter.mkdirs(active, getDirPath(i), new PermissionStatus("test", "test", new FsPermission((short)00755)), true); } - boolean exceptionThrown = false; try { checkForLogRoll(active, origTxId, noLogRollWaitTime); + fail("Expected to timeout"); } catch (TimeoutException e) { - exceptionThrown = true; + // expected } - assertTrue(exceptionThrown); + + long curTimeNew = standby.getNamesystem().getEditLogTailer().getTimer() Review comment: It this the `testTimer.monotinicNow()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 640433) Time Spent: 7h 20m (was: 7h 10m) > TestEditLogTailer#testStandbyTriggersLogRollsWhenTailInProgressEdits is flaky > ----------------------------------------------------------------------------- > > Key: HDFS-16143 > URL: https://issues.apache.org/jira/browse/HDFS-16143 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: test > Reporter: Akira Ajisaka > Assignee: Viraj Jasani > Priority: Major > Labels: pull-request-available > Attachments: patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt > > Time Spent: 7h 20m > Remaining Estimate: 0h > > https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3229/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt > {quote} > [ERROR] > testStandbyTriggersLogRollsWhenTailInProgressEdits[0](org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer) > Time elapsed: 6.862 s <<< FAILURE! > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:87) > at org.junit.Assert.assertTrue(Assert.java:42) > at org.junit.Assert.assertTrue(Assert.java:53) > at > org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer.testStandbyTriggersLogRollsWhenTailInProgressEdits(TestEditLogTailer.java:444) > {quote} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org