[ https://issues.apache.org/jira/browse/HDFS-6874?focusedWorklogId=642123&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-642123 ]
ASF GitHub Bot logged work on HDFS-6874: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Aug/21 03:25 Start Date: 26/Aug/21 03:25 Worklog Time Spent: 10m Work Description: jojochuang commented on a change in pull request #3322: URL: https://github.com/apache/hadoop/pull/3322#discussion_r696260085 ########## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java ########## @@ -908,4 +911,51 @@ private static SnapshotStatus toSnapshotStatus( SnapshotStatus.getParentPath(fullPath))); return snapshotStatus; } + + static BlockLocation[] toBlockLocationArray(Map<?, ?> json) + throws IOException { + final Map<?, ?> rootmap = + (Map<?, ?>) json.get(BlockLocation.class.getSimpleName() + "s"); + final List<?> array = + JsonUtilClient.getList(rootmap, BlockLocation.class.getSimpleName()); + Preconditions.checkNotNull(array); + final BlockLocation[] locations = new BlockLocation[array.size()]; + int i = 0; + for (Object object : array) { + final Map<?, ?> m = (Map<?, ?>) object; + locations[i++] = JsonUtilClient.toBlockLocation(m); + } + return locations; + } + + /** Convert a Json map to BlockLocation. **/ + static BlockLocation toBlockLocation(Map<?, ?> m) throws IOException { Review comment: this is only used by toBlockLocationArray() and the test of that covers it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 642123) Time Spent: 1h 40m (was: 1.5h) > Add GETFILEBLOCKLOCATIONS operation to HttpFS > --------------------------------------------- > > Key: HDFS-6874 > URL: https://issues.apache.org/jira/browse/HDFS-6874 > Project: Hadoop HDFS > Issue Type: Improvement > Components: httpfs > Affects Versions: 2.4.1, 2.7.3 > Reporter: Gao Zhong Liang > Assignee: Weiwei Yang > Priority: Major > Labels: BB2015-05-TBR, pull-request-available > Attachments: HDFS-6874-1.patch, HDFS-6874-branch-2.6.0.patch, > HDFS-6874.011.patch, HDFS-6874.02.patch, HDFS-6874.03.patch, > HDFS-6874.04.patch, HDFS-6874.05.patch, HDFS-6874.06.patch, > HDFS-6874.07.patch, HDFS-6874.08.patch, HDFS-6874.09.patch, > HDFS-6874.10.patch, HDFS-6874.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > GETFILEBLOCKLOCATIONS operation is missing in HttpFS, which is already > supported in WebHDFS. For the request of GETFILEBLOCKLOCATIONS in > org.apache.hadoop.fs.http.server.HttpFSServer, BAD_REQUEST is returned so far: > ....... > case GETFILEBLOCKLOCATIONS: { > response = Response.status(Response.Status.BAD_REQUEST).build(); > break; > } > ........ -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org