[
https://issues.apache.org/jira/browse/HDFS-16210?focusedWorklogId=646799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646799
]
ASF GitHub Bot logged work on HDFS-16210:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/21 08:49
Start Date: 06/Sep/21 08:49
Worklog Time Spent: 10m
Work Description: symious commented on a change in pull request #3379:
URL: https://github.com/apache/hadoop/pull/3379#discussion_r702721915
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/tools/federation/RouterAdmin.java
##########
@@ -1258,6 +1262,39 @@ public int genericRefresh(String[] argv, int i) throws
IOException {
}
}
+ /**
+ * Refresh Router's call Queue.
+ *
+ * @throws IOException if the operation was not successful.
+ */
+ private int refreshCallQueue() throws IOException {
+ Configuration conf = getConf();
+ String hostport = getConf().getTrimmed(
+ RBFConfigKeys.DFS_ROUTER_ADMIN_ADDRESS_KEY,
+ RBFConfigKeys.DFS_ROUTER_ADMIN_ADDRESS_DEFAULT);
+
+ // Create the client
+ Class<?> xface = RefreshCallQueueProtocolPB.class;
+ InetSocketAddress address = NetUtils.createSocketAddr(hostport);
+ UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
+
+ RPC.setProtocolEngine(conf, xface, ProtobufRpcEngine2.class);
+ RefreshCallQueueProtocolPB proxy =
(RefreshCallQueueProtocolPB)RPC.getProxy(
+ xface, RPC.getProtocolVersion(xface), address, ugi, conf,
+ NetUtils.getDefaultSocketFactory(conf), 0);
+
+ int returnCode = -1;
+ try (RefreshCallQueueProtocolClientSideTranslatorPB xlator =
+ new RefreshCallQueueProtocolClientSideTranslatorPB(proxy)) {
+ xlator.refreshCallQueue();
+ System.out.println("Refresh call queue successful for " + hostport);
Review comment:
@ferhui Thanks for the review.
Just to be sure, do you mean changing "successful" to "successfully" and
"failed" to "unsuccessfully"?
Borrowed from DFSAdmin, but the changes are good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646799)
Time Spent: 1h (was: 50m)
> Add the option of refreshCallQueue to RouterAdmin
> -------------------------------------------------
>
> Key: HDFS-16210
> URL: https://issues.apache.org/jira/browse/HDFS-16210
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Janus Chow
> Assignee: Janus Chow
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We enabled FairCallQueue to RouterRpcServer, but Router can not
> refreshCallQueue as NameNode does.
> This ticket is to enable the refreshCallQueue for Router so that we don't
> have to restart the Routers when updating FairCallQueue configurations.
>
> The option is not to refreshCallQueue to NameNodes, just trying to refresh
> the callQueue of Router itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
