[
https://issues.apache.org/jira/browse/HDFS-16181?focusedWorklogId=650929&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650929
]
ASF GitHub Bot logged work on HDFS-16181:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/21 02:52
Start Date: 15/Sep/21 02:52
Worklog Time Spent: 10m
Work Description: wzhallright edited a comment on pull request #3317:
URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919656426
> Can you address the checkstyle issue?
>
> ```
>
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:54:
MutableStat rpcRequestCacheMissAmount;:15: Variable
'rpcRequestCacheMissAmount' must be private and have accessor methods.
[VisibilityModifier]
> ```
>
> Previously with the `@Metric` annotation it had to be package-private to
be accessible to metrics2, but now it's no longer necessary and we can resolve
this by making it private.
>
> LGTM other than that, the only unit test failing is `TestBalancer` which I
have seen be flaky in the past and doesn't look related.
OK, I have fixed the checkstyle, PTAL,Thanks. @xkrogen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 650929)
Time Spent: 1h 40m (was: 1.5h)
> [SBN Read] Fix metric of RpcRequestCacheMissAmount can't display when
> tailEditLog form JN
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-16181
> URL: https://issues.apache.org/jira/browse/HDFS-16181
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: wangzhaohui
> Assignee: wangzhaohui
> Priority: Critical
> Labels: pull-request-available
> Attachments: after.jpg, before.jpg
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I found the JN turn on edit cache, but the metric of
> rpcRequestCacheMissAmount can not display.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
