[ https://issues.apache.org/jira/browse/HDFS-16230?focusedWorklogId=652645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652645 ]
ASF GitHub Bot logged work on HDFS-16230: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Sep/21 18:04 Start Date: 18/Sep/21 18:04 Worklog Time Spent: 10m Work Description: thomasleplus commented on a change in pull request #3455: URL: https://github.com/apache/hadoop/pull/3455#discussion_r711621922 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java ########## @@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception { restore = fsi.getStorage().getRestoreFailedStorage(); assertTrue("After check call restore is " + restore, restore); String commandOutput = cmdResult.getCommandOutput(); - commandOutput.trim(); + commandOutput = commandOutput.trim(); assertTrue(commandOutput.contains("restoreFailedStorage is set to true")); Review comment: Indeed. Now I realize that deleting my forked repo rather hastily was a mistake :( I've tried various ways to edit this PR branch but didn't succeed. It seems that it leaves us with two options: either I close this PR and open a new one, or someone with the right permissions edit it. Let me know what you think is best. Sorry for the inconvenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 652645) Time Spent: 40m (was: 0.5h) > Minor bug in TestStorageRestore > ------------------------------- > > Key: HDFS-16230 > URL: https://issues.apache.org/jira/browse/HDFS-16230 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Reporter: Thomas Leplus > Priority: Trivial > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Strings being immutable, you need to use the trim() method return value. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org