[ https://issues.apache.org/jira/browse/HDFS-16220?focusedWorklogId=652678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652678 ]
ASF GitHub Bot logged work on HDFS-16220: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Sep/21 06:47 Start Date: 19/Sep/21 06:47 Worklog Time Spent: 10m Work Description: jianghuazhu commented on a change in pull request #3417: URL: https://github.com/apache/hadoop/pull/3417#discussion_r711694180 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeMap.java ########## @@ -191,8 +202,28 @@ static INodeMap newInstance(INodeDirectory rootDir, return map.iterator(); } - private INodeMap(INodeDirectory rootDir, FSNamesystem ns) { + public Set<INode> rangeKeys() { + return ((PartitionedGSet)map).entryKeySet(); + } + + private static void setStaticField(Configuration conf) { + numSpaceKeyDepth = conf.getInt(DFSConfigKeys.DFS_NAMENODE_INOD_NAMESPACE_KEY_DEPTH, + DFSConfigKeys.DFS_NAMENODE_INOD_NAMESPACE_KEY_DEPTH_DEFAULT); + if (numSpaceKeyDepth < 1) { + numSpaceKeyDepth = DFSConfigKeys.DFS_NAMENODE_INOD_NAMESPACE_KEY_DEPTH_DEFAULT; + } + + numRanges = conf.getLong(DFSConfigKeys.DFS_NAMENODE_INOD_NUM_RANGES, Review comment: Thanks @xinglin for the comment. I will update it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 652678) Time Spent: 2h 50m (was: 2h 40m) > [FGL]Configurable INodeMap#NAMESPACE_KEY_DEPTH&NUM_RANGES_STATIC > ---------------------------------------------------------------- > > Key: HDFS-16220 > URL: https://issues.apache.org/jira/browse/HDFS-16220 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs, namenode > Reporter: JiangHua Zhu > Assignee: JiangHua Zhu > Priority: Major > Labels: pull-request-available > Attachments: debug1.jpg, debug2.jpg > > Time Spent: 2h 50m > Remaining Estimate: 0h > > In INodeMap, NAMESPACE_KEY_DEPTH and NUM_RANGES_STATIC are a fixed value, we > should make it configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org