[
https://issues.apache.org/jira/browse/HDFS-16235?focusedWorklogId=654877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654877
]
ASF GitHub Bot logged work on HDFS-16235:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/21 07:37
Start Date: 24/Sep/21 07:37
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3472:
URL: https://github.com/apache/hadoop/pull/3472#discussion_r715385382
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/impl/LeaseRenewer.java
##########
@@ -96,7 +96,9 @@ public static LeaseRenewer getInstance(final String authority,
* @param renewer Instance to be cleared from Factory
*/
public static void remove(LeaseRenewer renewer) {
- Factory.INSTANCE.remove(renewer);
+ synchronized (renewer) {
+ Factory.INSTANCE.remove(renewer);
Review comment:
INSTANCE is `static final` so we should synchronize on
`LeaseRenewer.class`. But anyways, isn't remove method already synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 654877)
Time Spent: 0.5h (was: 20m)
> Deadlock in LeaseRenewer for static remove method
> -------------------------------------------------
>
> Key: HDFS-16235
> URL: https://issues.apache.org/jira/browse/HDFS-16235
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: angerszhu
> Assignee: angerszhu
> Priority: Major
> Labels: pull-request-available
> Attachments: HDFS-16235.001.patch, image-2021-09-23-19-31-57-337.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> !image-2021-09-23-19-31-57-337.png|width=3339,height=1936!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
