[
https://issues.apache.org/jira/browse/HDFS-16238?focusedWorklogId=655349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655349
]
ASF GitHub Bot logged work on HDFS-16238:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/21 07:09
Start Date: 27/Sep/21 07:09
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3483:
URL: https://github.com/apache/hadoop/pull/3483#discussion_r716392145
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
##########
@@ -677,7 +677,7 @@ private boolean pathResolvesToId(final long zoneId, final
String zonePath)
* Cancels the currently-running re-encryption of the given encryption zone.
* If the given path is not the root of an encryption zone,
* an exception is thrown.
- * @param zoneIIP
+ * @param zoneIIP encryption zone inode path
Review comment:
same here
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
##########
@@ -645,8 +645,8 @@ private boolean pathResolvesToId(final long zoneId, final
String zonePath)
/**
* Re-encrypts the given encryption zone path. If the given path is not the
* root of an encryption zone, an exception is thrown.
- * @param zoneIIP
- * @param keyVersionName
+ * @param zoneIIP encryption zone inode path
Review comment:
nit: `encryption zone inodes in the path containing the file`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 655349)
Time Spent: 40m (was: 0.5h)
> Improve comments related to EncryptionZoneManager
> -------------------------------------------------
>
> Key: HDFS-16238
> URL: https://issues.apache.org/jira/browse/HDFS-16238
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, encryption, namenode
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In EncryptionZoneManager, there are some missing
> The description of the relevant comment. The purpose of this jira is to
> perfect them.
> E.g:
> /**
> * Re-encrypts the given encryption zone path. If the given path is not the
> * root of an encryption zone, an exception is thrown.
> * @param zoneIIP
> * @param keyVersionName
> * @throws IOException
> */
> List<XAttr> reencryptEncryptionZone(final INodesInPath zoneIIP,
> final String keyVersionName) throws IOException {
> ......
> }
> The description of zoneIIP and keyVersionName is missing here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
