[ https://issues.apache.org/jira/browse/HDFS-16244?focusedWorklogId=658721&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658721 ]
ASF GitHub Bot logged work on HDFS-16244: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Oct/21 03:21 Start Date: 01/Oct/21 03:21 Worklog Time Spent: 10m Work Description: jianghuazhu commented on pull request #3497: URL: https://github.com/apache/hadoop/pull/3497#issuecomment-931865021 Thanks @jojochuang for the comments and review. I found this issue(HDFS-16244) by accident. Yes, BackupNode is rarely used anymore. For the sake of system robustness, I propose this JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 658721) Time Spent: 1h (was: 50m) > Add the necessary write lock in Checkpointer#doCheckpoint() > ----------------------------------------------------------- > > Key: HDFS-16244 > URL: https://issues.apache.org/jira/browse/HDFS-16244 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: JiangHua Zhu > Assignee: JiangHua Zhu > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > When BackupNode is enabled, Checkpointer#doCheckpoint() will start to work. > When the image file needs to be reloaded, there is a call link, for example: > FSImage#reloadFromImageFile()->FSNamesystem#clear()->FSDirectory#reset(). > In FSDirectory#reset(), the write lock needs to be acquired in advance, for > example: > void reset() { > writeLock(); > try { > ...... > } finally { > writeUnlock(); > } > } > However, no write lock has been acquired before this. > You will get an exception message at this time, for example: > java.lang.AssertionError: Should hold namesystem write lock -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org