[ https://issues.apache.org/jira/browse/HDFS-16250?focusedWorklogId=659370&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659370 ]
ASF GitHub Bot logged work on HDFS-16250: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Oct/21 20:44 Start Date: 03/Oct/21 20:44 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3513: URL: https://github.com/apache/hadoop/pull/3513#issuecomment-933022434 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 24m 37s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 3 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 23m 45s | | trunk passed | | +1 :green_heart: | compile | 2m 52s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 34s | | trunk passed | | +1 :green_heart: | shadedclient | 48m 30s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 19s | | the patch passed | | +1 :green_heart: | compile | 2m 44s | | the patch passed | | +1 :green_heart: | cc | 2m 44s | | the patch passed | | +1 :green_heart: | golang | 2m 44s | | the patch passed | | +1 :green_heart: | javac | 2m 44s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 23s | | the patch passed | | +1 :green_heart: | shadedclient | 21m 3s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 109m 31s | | hadoop-hdfs-native-client in the patch passed. | | +1 :green_heart: | asflicense | 0m 39s | | The patch does not generate ASF License warnings. | | | | 210m 12s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3513/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/3513 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell golang | | uname | Linux 1f60cff78c1c 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / d25f479760cdca063c9a2624dcdd90d61d5f0376 | | Default Java | Red Hat, Inc.-1.8.0_302-b08 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3513/1/testReport/ | | Max. process+thread count | 520 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3513/1/console | | versions | git=2.27.0 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 659370) Time Spent: 0.5h (was: 20m) > Refactor AllowSnapshotMock using GMock > -------------------------------------- > > Key: HDFS-16250 > URL: https://issues.apache.org/jira/browse/HDFS-16250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs++ > Affects Versions: 3.4.0 > Reporter: Gautham Banasandra > Assignee: Gautham Banasandra > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, the > [implementation|https://github.com/apache/hadoop/blob/35a8d48872a13438d4c4199b6ef5b902105e2eb2/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/tools/hdfs-allow-snapshot-mock.cc] > of AllowSnapshotMock is quite basic. Need to replace this with GMock so that > we can tap into the benefits offered by GMock. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org