[
https://issues.apache.org/jira/browse/HDFS-16277?focusedWorklogId=668710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668710
]
ASF GitHub Bot logged work on HDFS-16277:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/21 00:02
Start Date: 22/Oct/21 00:02
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on a change in pull request #3559:
URL: https://github.com/apache/hadoop/pull/3559#discussion_r734123264
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/AvailableSpaceRackFaultTolerantBlockPlacementPolicy.java
##########
@@ -54,6 +57,10 @@ public void initialize(Configuration conf, FSClusterStats
stats,
DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY,
DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_RACK_FAULT_TOLERANT_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_DEFAULT);
+ balancedSpaceTolerance = conf.getInt(
+
DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_KEY,
+
DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_RACK_FAULT_TOLERANT_PLACEMENT_POLICY_BALANCED_SPACE_TOLERANCE_DEFAULT);
Review comment:
Thanks @prasad-acit for your advice ,it should be used for total new
code , for now, if we cut ir for short, the variable name meaning may not that
clear,maybe we can igonre it, and apply the short name as far as possible in
furture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 668710)
Time Spent: 4h 40m (was: 4.5h)
> improve decision in AvailableSpaceBlockPlacementPolicy
> ------------------------------------------------------
>
> Key: HDFS-16277
> URL: https://issues.apache.org/jira/browse/HDFS-16277
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: block placement
> Affects Versions: 3.3.1
> Reporter: guo
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Hi
> In product environment,we may meet two or more datanode usage reaches nealy
> 100%,for exampe 99.99%,98%,97%.
> if we configure `AvailableSpaceBlockPlacementPolicy` , we also have the
> chance to choose the 99.99%(assume it is the highest usage),for we treat the
> two choosen datanode as the same usage if their storage usage are different
> within 5%.
> but this is not what we want, so i suggest we can improve the decision.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
