[ https://issues.apache.org/jira/browse/HDFS-16296?focusedWorklogId=674814&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-674814 ]
ASF GitHub Bot logged work on HDFS-16296: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Nov/21 17:52 Start Date: 03/Nov/21 17:52 Worklog Time Spent: 10m Work Description: goiri commented on a change in pull request #3613: URL: https://github.com/apache/hadoop/pull/3613#discussion_r742196019 ########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/fairness/TestRouterHandlersFairness.java ########## @@ -208,4 +212,15 @@ private void invokeConcurrent(ClientProtocol routerProto, String clientName) routerProto.renewLease(clientName); } + private int getTotalRejectedPermits(RouterContext routerContext) { + int totalRejectedPermits = 0; + for (String ns : cluster.getNameservices()) { + totalRejectedPermits += routerContext.getRouter().getRpcServer() Review comment: We may want to extract: routerContext.getRouter().getRpcServer().getRPCClient() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 674814) Time Spent: 1h (was: 50m) > RBF: RouterRpcFairnessPolicyController add denied permits for each nameservice > ------------------------------------------------------------------------------ > > Key: HDFS-16296 > URL: https://issues.apache.org/jira/browse/HDFS-16296 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Janus Chow > Assignee: Janus Chow > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Currently RouterRpcFairnessPolicyController has a metric of > "getProxyOpPermitRejected" to show the total rejected invokes due to lack of > permits. > This ticket is to add the metrics for each nameservice to have a better view > of the load of each nameservice. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org