[
https://issues.apache.org/jira/browse/HDFS-16287?focusedWorklogId=675371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675371
]
ASF GitHub Bot logged work on HDFS-16287:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 00:44
Start Date: 04/Nov/21 00:44
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3596:
URL: https://github.com/apache/hadoop/pull/3596#discussion_r742015162
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that when ```excludeSlowNodesEnabled``` is set to true we
```startSlowPeerCollector```, and ```stopSlowPeerCollector``` when
```excludeSlowNodesEnabled``` is set to false. There is no extra overhead. What
do you think?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that only when ```excludeSlowNodesEnabled``` is set to true we
```startSlowPeerCollector```, and ```stopSlowPeerCollector``` when
```excludeSlowNodesEnabled``` is set to false. There is no extra overhead. What
do you think?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that only when `excludeSlowNodesEnabled` is set to `true` we
`startSlowPeerCollector`, and `stopSlowPeerCollector` when
`excludeSlowNodesEnabled` is set to `false`. There is no extra overhead. What
do you think?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that when ```excludeSlowNodesEnabled``` is set to true we
```startSlowPeerCollector```, and ```stopSlowPeerCollector``` when
```excludeSlowNodesEnabled``` is set to false. There is no extra overhead. What
do you think?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that only when ```excludeSlowNodesEnabled``` is set to true we
```startSlowPeerCollector```, and ```stopSlowPeerCollector``` when
```excludeSlowNodesEnabled``` is set to false. There is no extra overhead. What
do you think?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
##########
@@ -511,7 +505,16 @@ private boolean isInactive(DatanodeInfo datanode) {
private boolean isSlowNode(String dnUuid) {
return avoidSlowDataNodesForRead && slowNodesUuidSet.contains(dnUuid);
}
-
+
+ public void setAvoidSlowDataNodesForReadEnabled(boolean enable) {
Review comment:
Thanks @haiyang1987 for your comment. I think the logic right now is no
problem.
I mean that only when `excludeSlowNodesEnabled` is set to `true` we
`startSlowPeerCollector`, and `stopSlowPeerCollector` when
`excludeSlowNodesEnabled` is set to `false`. There is no extra overhead. What
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 675371)
Time Spent: 6h 40m (was: 6.5h)
> Support to make dfs.namenode.avoid.read.slow.datanode reconfigurable
> ---------------------------------------------------------------------
>
> Key: HDFS-16287
> URL: https://issues.apache.org/jira/browse/HDFS-16287
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> 1. Consider that make dfs.namenode.avoid.read.slow.datanode reconfigurable
> and rapid rollback in case this feature
> [HDFS-16076|https://issues.apache.org/jira/browse/HDFS-16076] unexpected
> things happen in production environment
> 2. DatanodeManager#startSlowPeerCollector by parameter
> 'dfs.datanode.peer.stats.enabled' to control
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
