[
https://issues.apache.org/jira/browse/HDFS-16291?focusedWorklogId=675707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-675707
]
ASF GitHub Bot logged work on HDFS-16291:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 01:20
Start Date: 04/Nov/21 01:20
Worklog Time Spent: 10m
Work Description: ferhui commented on a change in pull request #3602:
URL: https://github.com/apache/hadoop/pull/3602#discussion_r741639733
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
##########
@@ -993,15 +993,13 @@ public long getNsDelta() {
private final QuotaDelta quotaDelta;
/**
- * @param bsps
- * block storage policy suite to calculate intended storage type
Review comment:
How about just adding the same blanks on line 997 and below wrong format
lines as line 996, and do not change other lines.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INode.java
##########
@@ -993,15 +993,13 @@ public long getNsDelta() {
private final QuotaDelta quotaDelta;
/**
- * @param bsps
- * block storage policy suite to calculate intended storage type
Review comment:
How about just adding the same blanks on line 997 and below wrong format
lines as line 996, and do not change other lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 675707)
Time Spent: 3h (was: 2h 50m)
> Make the comment of INode#ReclaimContext more standardized
> ----------------------------------------------------------
>
> Key: HDFS-16291
> URL: https://issues.apache.org/jira/browse/HDFS-16291
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: documentation, namenode
> Affects Versions: 3.4.0
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2021-10-31-20-25-08-379.png
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> In the INode#ReclaimContext class, there are some comments that are not
> standardized enough.
> E.g:
> !image-2021-10-31-20-25-08-379.png!
> We should make comments more standardized. This will be more readable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
