[
https://issues.apache.org/jira/browse/HDFS-16287?focusedWorklogId=678334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678334
]
ASF GitHub Bot logged work on HDFS-16287:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/21 03:36
Start Date: 08/Nov/21 03:36
Worklog Time Spent: 10m
Work Description: haiyang1987 commented on a change in pull request #3596:
URL: https://github.com/apache/hadoop/pull/3596#discussion_r744385743
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
##########
@@ -394,6 +395,23 @@ public void testEnableParallelLoadAfterReconfigured()
assertEquals(true, FSImageFormatProtobuf.getEnableParallelLoad());
}
+ @Test
+ public void testEnableSlowNodesParametersAfterReconfigured()
+ throws ReconfigurationException {
+ final NameNode nameNode = cluster.getNameNode();
+ final DatanodeManager datanodeManager = nameNode.namesystem
+ .getBlockManager().getDatanodeManager();
+
+ // By default, avoidSlowDataNodesForRead is false
+ assertEquals(false, datanodeManager.getEnableAvoidSlowDataNodesForRead());
+
+ nameNode.reconfigureProperty(
+ DFS_NAMENODE_AVOID_SLOW_DATANODE_FOR_READ_KEY, Boolean.toString(true));
+
+ // After reconfigured, avoidSlowDataNodesForRead is true
Review comment:
Thanks @tomscut for your comment. PR update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 678334)
Time Spent: 10.5h (was: 10h 20m)
> Support to make dfs.namenode.avoid.read.slow.datanode reconfigurable
> ---------------------------------------------------------------------
>
> Key: HDFS-16287
> URL: https://issues.apache.org/jira/browse/HDFS-16287
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> 1. Consider that make dfs.namenode.avoid.read.slow.datanode reconfigurable
> and rapid rollback in case this feature
> [HDFS-16076|https://issues.apache.org/jira/browse/HDFS-16076] unexpected
> things happen in production environment
> 2. DatanodeManager#startSlowPeerCollector by parameter
> 'dfs.datanode.peer.stats.enabled' to control
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
