[
https://issues.apache.org/jira/browse/HDFS-16321?focusedWorklogId=681106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-681106
]
ASF GitHub Bot logged work on HDFS-16321:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/21 14:00
Start Date: 13/Nov/21 14:00
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on a change in pull request #3655:
URL: https://github.com/apache/hadoop/pull/3655#discussion_r748726616
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceRackFaultTolerantBPP.java
##########
@@ -189,6 +189,13 @@ public void testChooseDataNode() {
}
}
+ @Test
+ public void testDefaultConfigValue() {
+ Assert.assertEquals(
+
conf.get("DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY")
+ ,0.6f);
+ }
+
Review comment:
> This isn't required, this isn't checking the BPP, but how the conf
object works. you can remove this test.
Thanks @ayushtkn for your review. I have removed the test case, but not sure
if the CI will pass if no tests added. hope it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 681106)
Time Spent: 0.5h (was: 20m)
> Fix invalid config in TestAvailableSpaceRackFaultTolerantBPP
> -------------------------------------------------------------
>
> Key: HDFS-16321
> URL: https://issues.apache.org/jira/browse/HDFS-16321
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 3.3.1
> Reporter: guo
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> `TestAvailableSpaceRackFaultTolerantBPP` seems setting invalid param(valid in
> `TestAvailableSpaceBlockPlacementPolicy`), we can fix it to avoid further
> trouble.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
