[
https://issues.apache.org/jira/browse/HDFS-16350?focusedWorklogId=685300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685300
]
ASF GitHub Bot logged work on HDFS-16350:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 14:33
Start Date: 23/Nov/21 14:33
Worklog Time Spent: 10m
Work Description: virajjasani edited a comment on pull request #3711:
URL: https://github.com/apache/hadoop/pull/3711#issuecomment-976586442
Starttime calculation for Namenode and Router seem better than Datanode
case, because it's not the main classes that have starttime defined (i.e.
NameNode and DFSRouter) but rather other classes that are internally
initialized (e.g. FSNamesystem and Router) as part of the main process
initialization, have the starttime defined. In the case of Datanode, the main
class itself (i.e. DataNode) has starttime defined but it is initialized soon
as the Datanode is instantiated. Hence, I think we can improve only Datanode's
starttime to match with the actual process start time.
I understand that for a healthy process initialization, there should not be
much difference in starttime if we keep it at instance init level (without this
patch) vs if we keep it soon after RPC server is started (with this patch), but
my concern is that if for some reason, RPC handler start time is significantly
delayed, then we would have incorrect starttime reported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 685300)
Time Spent: 1h 40m (was: 1.5h)
> Datanode start time should be set after RPC server starts successfully
> ----------------------------------------------------------------------
>
> Key: HDFS-16350
> URL: https://issues.apache.org/jira/browse/HDFS-16350
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Minor
> Labels: pull-request-available
> Attachments: Screenshot 2021-11-23 at 4.32.04 PM.png
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We set start time of Datanode when the class is instantiated but it should be
> ideally set only after RPC server starts and RPC handlers are initialized to
> serve client requests.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
