[ 
https://issues.apache.org/jira/browse/HDFS-16338?focusedWorklogId=686221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-686221
 ]

ASF GitHub Bot logged work on HDFS-16338:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Nov/21 05:03
            Start Date: 25/Nov/21 05:03
    Worklog Time Spent: 10m 
      Work Description: tomscut commented on a change in pull request #3684:
URL: https://github.com/apache/hadoop/pull/3684#discussion_r756573192



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImage.java
##########
@@ -275,6 +276,31 @@ public void testSaveAndLoadStripedINodeFile() throws 
IOException{
     }
   }
 
+  @Test
+  public void testImportCheckpoint() throws IOException{

Review comment:
       A little advice. You can consider using try with resources for 
`MiniDFSCluster cluster = new MiniDFSCluster.Builder(config).build()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 686221)
    Time Spent: 1h 10m  (was: 1h)

> Fix error configuration message in FSImage
> ------------------------------------------
>
>                 Key: HDFS-16338
>                 URL: https://issues.apache.org/jira/browse/HDFS-16338
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.3.1
>            Reporter: guo
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> `dfs.namenode.checkpoint.edits.dir` may be different from 
> `dfs.namenode.checkpoint.dir` , if `checkpointEditsDirs` is null or empty, 
> error message should warn the edit dir configuration, we can fix it.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to