[ 
https://issues.apache.org/jira/browse/HDFS-16357?focusedWorklogId=690133&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690133
 ]

ASF GitHub Bot logged work on HDFS-16357:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Dec/21 16:14
            Start Date: 03/Dec/21 16:14
    Worklog Time Spent: 10m 
      Work Description: ayushtkn commented on a change in pull request #3729:
URL: https://github.com/apache/hadoop/pull/3729#discussion_r762068062



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
##########
@@ -733,13 +733,13 @@ public static boolean isLocalAddress(InetSocketAddress 
targetAddr)
     InetAddress addr = targetAddr.getAddress();
     Boolean cached = localAddrMap.get(addr.getHostAddress());
     if (cached != null) {
-      LOG.trace("Address {} is {} local", targetAddr, (cached ? "" : "not"));
+      LOG.trace("Address " + targetAddr + (cached ? " is local" : " is not 
local"));

Review comment:
       The present change Looks good to me, What is the problem in that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 690133)
    Time Spent: 1h  (was: 50m)

> Fix log format in DFSUtilClient
> -------------------------------
>
>                 Key: HDFS-16357
>                 URL: https://issues.apache.org/jira/browse/HDFS-16357
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>    Affects Versions: 3.3.1
>            Reporter: guophilipse
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> if address is local ,there will be additional space in the log .we can 
> improve it to look proper



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to