[
https://issues.apache.org/jira/browse/HDFS-16314?focusedWorklogId=690193&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690193
]
ASF GitHub Bot logged work on HDFS-16314:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/21 17:17
Start Date: 03/Dec/21 17:17
Worklog Time Spent: 10m
Work Description: aajisaka commented on a change in pull request #3664:
URL: https://github.com/apache/hadoop/pull/3664#discussion_r762113040
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicy.java
##########
@@ -261,4 +261,16 @@ protected String getRack(final DatanodeInfo datanode) {
}
}
}
+
+ /**
+ * Updates the value used for excludeSlowNodesEnabled, which is set by
+ * {@code
DFSConfigKeys.DFS_NAMENODE_BLOCKPLACEMENTPOLICY_EXCLUDE_SLOW_NODES_ENABLED_KEY}
+ * initially.
+ *
+ * @param enable true, we will filter out slow nodes
+ * when choosing targets for blocks, otherwise false not filter.
+ */
+ public abstract void setExcludeSlowNodesEnabled(boolean enable);
+
+ public abstract boolean getExcludeSlowNodesEnabled();
Review comment:
This interface is marked as `@Private`, so adding abstract methods is
okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 690193)
Time Spent: 3.5h (was: 3h 20m)
> Support to make
> dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-16314
> URL: https://issues.apache.org/jira/browse/HDFS-16314
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Consider that make
> dfs.namenode.block-placement-policy.exclude-slow-nodes.enabled reconfigurable
> and rapid rollback in case this feature HDFS-16076 unexpected things happen
> in production environment
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
