[
https://issues.apache.org/jira/browse/HDFS-16370?focusedWorklogId=690448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690448
]
ASF GitHub Bot logged work on HDFS-16370:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/21 05:53
Start Date: 04/Dec/21 05:53
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3747:
URL: https://github.com/apache/hadoop/pull/3747#discussion_r762390295
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
##########
@@ -146,7 +146,7 @@ BlockInfo getNext(int index) {
BlockInfo info = (BlockInfo)triplets[index*3+2];
assert info == null || info.getClass().getName().startsWith(
BlockInfo.class.getName()) :
- "BlockInfo is expected at " + index*3;
+ "BlockInfo is expected at " + (index*3+2);
Review comment:
Same as above, Can you pad some space between the values
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockInfo.java
##########
@@ -136,7 +136,7 @@ BlockInfo getPrevious(int index) {
BlockInfo info = (BlockInfo)triplets[index*3+1];
assert info == null ||
info.getClass().getName().startsWith(BlockInfo.class.getName()) :
- "BlockInfo is expected at " + index*3;
+ "BlockInfo is expected at " + (index*3+1);
Review comment:
nit: Better to have some space around the values
```suggestion
"BlockInfo is expected at " + (index * 3 + 1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 690448)
Time Spent: 0.5h (was: 20m)
> Fix assert message for BlockInfo
> --------------------------------
>
> Key: HDFS-16370
> URL: https://issues.apache.org/jira/browse/HDFS-16370
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In both methods BlockInfo#getPrevious and BlockInfo#getNext, the assert
> message is wrong. This may cause some misunderstanding and needs to be fixed.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
