[
https://issues.apache.org/jira/browse/HDFS-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453298#comment-17453298
]
Ayush Saxena commented on HDFS-13947:
-------------------------------------
Hey Folks,
Observed this while checking HDFS-16347. This patch changed the default value
in DfsConfigKeys but not in hdfs-defaults:
{code:java}
DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY =
"dfs.datanode.directoryscan.throttle.limit.ms.per.sec";
public static final int
- DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT = 1000;
+ DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT = -1;
{code}
Was that a miss or the change here is accidental. If we changed the default
value we should have put that in the release notes for others to know.
Let me know if that was intentional, if so we can get HDFS-16347 in and update
release notes there
> Review of DirectoryScanner Class
> --------------------------------
>
> Key: HDFS-13947
> URL: https://issues.apache.org/jira/browse/HDFS-13947
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Fix For: 3.3.0
>
> Attachments: HDFS-13947.1.patch, HDFS-13947.2.patch,
> HDFS-13947.3.patch, HDFS-13947.4.patch, HDFS-13947.5.patch
>
>
> Review of Directory Scanner. Replaced a lot of code with Guava MultiMap.
> Some general house cleaning and improved logging. For performance, using
> {{ArrayList}} instead of {{LinkedList}} where possible, especially since
> these lists can be quite large a LinkedList will consume a lot of memory and
> be slow to sort/iterate over.
> https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist-in-java
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
