[ https://issues.apache.org/jira/browse/HDFS-16338?focusedWorklogId=690819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690819 ]
ASF GitHub Bot logged work on HDFS-16338: ----------------------------------------- Author: ASF GitHub Bot Created on: 06/Dec/21 08:39 Start Date: 06/Dec/21 08:39 Worklog Time Spent: 10m Work Description: virajjasani commented on a change in pull request #3684: URL: https://github.com/apache/hadoop/pull/3684#discussion_r762794855 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java ########## @@ -582,12 +582,12 @@ void doImportCheckpoint(FSNamesystem target) throws IOException { if (checkpointDirs == null || checkpointDirs.isEmpty()) { throw new IOException("Cannot import image from a checkpoint. " - + "\"dfs.namenode.checkpoint.dir\" is not set." ); + + "\"dfs.namenode.checkpoint.dir\" is not set."); } if (checkpointEditsDirs == null || checkpointEditsDirs.isEmpty()) { Review comment: Btw `checkpointDirs` and `checkpointEditsDirs` will not be null as they are assigned values returned by `FSImage.getCheckpointDirs` and `FSImage.getCheckpointEditsDirs` respectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 690819) Time Spent: 3h 40m (was: 3.5h) > Fix error configuration message in FSImage > ------------------------------------------ > > Key: HDFS-16338 > URL: https://issues.apache.org/jira/browse/HDFS-16338 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs > Affects Versions: 3.3.1 > Reporter: guophilipse > Assignee: guophilipse > Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 3h 40m > Remaining Estimate: 0h > > `dfs.namenode.checkpoint.edits.dir` may be different from > `dfs.namenode.checkpoint.dir` , if `checkpointEditsDirs` is null or empty, > error message should warn the edit dir configuration, we can fix it. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org