[
https://issues.apache.org/jira/browse/HDFS-16345?focusedWorklogId=690834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690834
]
ASF GitHub Bot logged work on HDFS-16345:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/21 08:58
Start Date: 06/Dec/21 08:58
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on a change in pull request #3696:
URL: https://github.com/apache/hadoop/pull/3696#discussion_r762809175
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockStoragePolicy.java
##########
@@ -1274,23 +1274,29 @@ public void testChooseTargetWithTopology() throws
Exception {
DFSTestUtil.formatNameNode(conf);
NameNode namenode = new NameNode(conf);
- final BlockManager bm = namenode.getNamesystem().getBlockManager();
- BlockPlacementPolicy replicator = bm.getBlockPlacementPolicy();
- NetworkTopology cluster = bm.getDatanodeManager().getNetworkTopology();
- for (DatanodeDescriptor datanode : dataNodes) {
- cluster.add(datanode);
- }
-
- DatanodeStorageInfo[] targets = replicator.chooseTarget("/foo", 3,
- dataNodes[0], Collections.<DatanodeStorageInfo>emptyList(), false,
- new HashSet<Node>(), 0, policy1, null);
- System.out.println(Arrays.asList(targets));
- Assert.assertEquals(3, targets.length);
- targets = replicator.chooseTarget("/foo", 3,
- dataNodes[0], Collections.<DatanodeStorageInfo>emptyList(), false,
- new HashSet<Node>(), 0, policy2, null);
- System.out.println(Arrays.asList(targets));
- Assert.assertEquals(3, targets.length);
+ try{
Review comment:
>
Thanks @ayushtkn , will update it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 690834)
Time Spent: 1h 40m (was: 1.5h)
> Fix test cases fail in TestBlockStoragePolicy
> ---------------------------------------------
>
> Key: HDFS-16345
> URL: https://issues.apache.org/jira/browse/HDFS-16345
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.3.1
> Reporter: guophilipse
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> test class ``TestBlockStoragePolicy` ` fail frequently for the
> `BindException`, it block all normal source code build. we can improve it.
> [ERROR] Tests run: 26, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 49.295 s <<< FAILURE! - in org.apache.hadoop.hdfs.TestBlockStoragePolicy
> [ERROR]
> testChooseTargetWithTopology(org.apache.hadoop.hdfs.TestBlockStoragePolicy)
> Time elapsed: 0.551 s <<< ERROR! java.net.BindException: Problem binding to
> [localhost:43947] java.net.BindException: Address already in use; For more
> details see: http://wiki.apache.org/hadoop/BindException at
> sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at
> org.apache.hadoop.net.NetUtils.wrapWithMessage(NetUtils.java:931) at
> org.apache.hadoop.net.NetUtils.wrapException(NetUtils.java:827) at
> org.apache.hadoop.ipc.Server.bind(Server.java:657) at
> org.apache.hadoop.ipc.Server$Listener.<init>(Server.java:1352) at
> org.apache.hadoop.ipc.Server.<init>(Server.java:3252) at
> org.apache.hadoop.ipc.RPC$Server.<init>(RPC.java:1062) at
> org.apache.hadoop.ipc.ProtobufRpcEngine2$Server.<init>(ProtobufRpcEngine2.java:468)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine2.getServer(ProtobufRpcEngine2.java:371)
> at org.apache.hadoop.ipc.RPC$Builder.build(RPC.java:853) at
> org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.<init>(NameNodeRpcServer.java:466)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.createRpcServer(NameNode.java:860)
> at
> org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:766)
> at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:1017)
> at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:992)
> at
> org.apache.hadoop.hdfs.TestBlockStoragePolicy.testChooseTargetWithTopology(TestBlockStoragePolicy.java:1275)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at
> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at
> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at
> org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at
> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at
> org.junit.runners.ParentRunner.run(ParentRunner.java:413) at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> Caused by: java.net.BindException: Address already in use at
> sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:461) at
> sun.nio.ch.Net.bind(Net.java:453) at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:222) at
> sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:85) at
> org.apache.hadoop.ipc.Server.bind(Server.java:640) ... 40 more
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
