[ https://issues.apache.org/jira/browse/HDFS-16378?focusedWorklogId=694381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694381 ]
ASF GitHub Bot logged work on HDFS-16378: ----------------------------------------- Author: ASF GitHub Bot Created on: 11/Dec/21 04:44 Start Date: 11/Dec/21 04:44 Worklog Time Spent: 10m Work Description: Hexiaoqiao commented on pull request #3786: URL: https://github.com/apache/hadoop/pull/3786#issuecomment-991458334 Thanks @tomscut for your report. It is almost LGTM. Some nits, a. There are also some other logs which only leaves DataNodeUUID, do you mind to complete them with address together? b. Just suggest to invoke `dn.getXferAddr()` to keep the log style same. e.g. `200 LOG.info("Registered DN {} ({}).", dn.getDatanodeUuid(), dn.getXferAddr());` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 694381) Time Spent: 20m (was: 10m) > Add datanode address to BlockReportLeaseManager logs > ---------------------------------------------------- > > Key: HDFS-16378 > URL: https://issues.apache.org/jira/browse/HDFS-16378 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: tomscut > Assignee: tomscut > Priority: Minor > Labels: pull-request-available > Attachments: image-2021-12-11-09-58-59-494.png > > Time Spent: 20m > Remaining Estimate: 0h > > We should add datanode address to BlockReportLeaseManager logs. Because the > datanodeuuid is not convenient for tracking. > !image-2021-12-11-09-58-59-494.png|width=643,height=152! -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org