[
https://issues.apache.org/jira/browse/HDFS-16400?focusedWorklogId=706767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706767
]
ASF GitHub Bot logged work on HDFS-16400:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 10:43
Start Date: 11/Jan/22 10:43
Worklog Time Spent: 10m
Work Description: tasanuma commented on a change in pull request #3843:
URL: https://github.com/apache/hadoop/pull/3843#discussion_r782022532
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -647,13 +650,37 @@ public String reconfigurePropertyImpl(String property,
String newVal)
}
break;
}
+ case DFS_DATANODE_MAX_RECEIVER_THREADS_KEY:
+ return reconfDataXceiverParameters(property, newVal);
default:
break;
}
throw new ReconfigurationException(
property, newVal, getConf().get(property));
}
+ private String reconfDataXceiverParameters(String property, String newVal)
+ throws ReconfigurationException {
+ String result;
+ try {
+ LOG.info("Reconfiguring {} to {}", property, newVal);
+ if (property.equals(DFS_DATANODE_MAX_RECEIVER_THREADS_KEY)) {
Review comment:
The if-statement seems redundant since it is already checked by `case
DFS_DATANODE_MAX_RECEIVER_THREADS_KEY `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 706767)
Time Spent: 1h (was: 50m)
> Reconfig DataXceiver parameters for datanode
> --------------------------------------------
>
> Key: HDFS-16400
> URL: https://issues.apache.org/jira/browse/HDFS-16400
> Project: Hadoop HDFS
> Issue Type: New Feature
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> To avoid frequent rolling restarts of the DN, we should make DataXceiver
> parameters reconfigurable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
