[ 
https://issues.apache.org/jira/browse/HDFS-16426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479301#comment-17479301
 ] 

Tamas Domok edited comment on HDFS-16426 at 1/20/22, 12:06 PM:
---------------------------------------------------------------

Hi!

This breaks the build on branch-3.2:

{code}
[ERROR] 
/Users/tdomok/Work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBpServiceActorScheduler.java:[151,27]
 cannot find symbol
[ERROR]   symbol:   method getNextBlockReportTime()
[ERROR]   location: variable scheduler of type 
org.apache.hadoop.hdfs.server.datanode.BPServiceActor.Scheduler
[ERROR] 
/Users/tdomok/Work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBpServiceActorScheduler.java:[152,27]
 cannot find symbol
[ERROR]   symbol:   method getNextBlockReportTime()
[ERROR]   location: variable scheduler of type 
org.apache.hadoop.hdfs.server.datanode.BPServiceActor.Scheduler
{code}

The getNextBlockReportTime is not available on branch-3.2. Could you revert or 
fix the change [~qinyuren]? Thanks.


was (Author: tdomok):
Hi!

This breaks the build on branch-3.2:

{code}
[ERROR] 
/Users/tdomok/Work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBpServiceActorScheduler.java:[151,27]
 cannot find symbol
[ERROR]   symbol:   method getNextBlockReportTime()
[ERROR]   location: variable scheduler of type 
org.apache.hadoop.hdfs.server.datanode.BPServiceActor.Scheduler
[ERROR] 
/Users/tdomok/Work/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBpServiceActorScheduler.java:[152,27]
 cannot find symbol
[ERROR]   symbol:   method getNextBlockReportTime()
[ERROR]   location: variable scheduler of type 
org.apache.hadoop.hdfs.server.datanode.BPServiceActor.Scheduler
{code}

The getNextBlockReportTime is not available on branch-3.2.

> fix nextBlockReportTime when trigger full block report force
> ------------------------------------------------------------
>
>                 Key: HDFS-16426
>                 URL: https://issues.apache.org/jira/browse/HDFS-16426
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: qinyuren
>            Assignee: qinyuren
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.2.4, 3.3.3
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> When we trigger full block report force by command line, the next block 
> report time will be set like this:
> nextBlockReportTime.getAndAdd(blockReportIntervalMs);
> nextBlockReportTime will larger than blockReportIntervalMs.
> If we trigger full block report twice, the nextBlockReportTime will larger 
> than 2 * blockReportIntervalMs. This is obviously not what we want.
> We fix the nextBlockReportTime = now + blockReportIntervalMs after full block 
> report trigger by command line.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to