[ https://issues.apache.org/jira/browse/HDFS-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186659#comment-13186659 ]
Todd Lipcon commented on HDFS-2747: ----------------------------------- - add braces around the body of the new if statement - typo in test name: "ShoulNot" - parameter should capitalize "namesystem" not "nameSystem" since it is FSNamesystem, not FSNameSystem -- I also think NameNodeAdapter is probably a better spot for this than FSImageTestUtil - In the javadoc for the new tests, can you mention that it is a regression test for HDFS-2747? I think it's useful for future maintenance of the tests to be able to refer back to the discussion on this bug. Thanks! > HA: entering safe mode after starting SBN can NPE > ------------------------------------------------- > > Key: HDFS-2747 > URL: https://issues.apache.org/jira/browse/HDFS-2747 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ha > Affects Versions: HA branch (HDFS-1623) > Reporter: Eli Collins > Assignee: Uma Maheswara Rao G > Attachments: HDFS-2747.patch > > > Entering Safemode on the primary after while it's already in safemode after > the SBN is started results in an NPE: > {noformat} > hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs dfsadmin -safemode get > Safe mode is ON > hadoop-0.24.0-SNAPSHOT $ ./bin/hdfs dfsadmin -safemode enter > safemode: java.lang.NullPointerException > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira