[
https://issues.apache.org/jira/browse/HDFS-16440?focusedWorklogId=723834&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723834
]
ASF GitHub Bot logged work on HDFS-16440:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 17:21
Start Date: 09/Feb/22 17:21
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3971:
URL: https://github.com/apache/hadoop/pull/3971#discussion_r802909602
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNamenodeHeartbeat.java
##########
@@ -211,6 +216,54 @@ public void testHearbeat() throws InterruptedException,
IOException {
assertEquals(NAMENODES[1], standby.getNamenodeId());
}
+ @Test
+ public void testNamenodeHeartbeatServiceHAServiceProtocolProxy(){
+ testNamenodeHeartbeatServiceHAServiceProtocol(
+ "test-ns", "nn", 1000, -1, -1, 1003,
Review comment:
The spacing doesn't look correct.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterNamenodeHeartbeat.java
##########
@@ -50,13 +50,18 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Test the service that heartbeats the state of the namenodes to the State
* Store.
*/
public class TestRouterNamenodeHeartbeat {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(TestRouterNamenodeHeartbeat.class);
Review comment:
The space doesn't look correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 723834)
Time Spent: 0.5h (was: 20m)
> RBF: Support router get HAServiceStatus with Lifeline RPC address
> -----------------------------------------------------------------
>
> Key: HDFS-16440
> URL: https://issues.apache.org/jira/browse/HDFS-16440
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: rbf
> Reporter: YulongZ
> Priority: Minor
> Labels: pull-request-available
> Attachments: HDFS-16440.001.patch, HDFS-16440.003.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> NamenodeHeartbeatService gets HAServiceStatus using
> NNHAServiceTarget.getProxy. When we set a special
> dfs.namenode.lifeline.rpc-address , NamenodeHeartbeatService may get
> HAServiceStatus using NNHAServiceTarget.getHealthMonitorProxy.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
