[ 
https://issues.apache.org/jira/browse/HDFS-16478?focusedWorklogId=731840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-731840
 ]

ASF GitHub Bot logged work on HDFS-16478:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Feb/22 19:25
            Start Date: 23/Feb/22 19:25
    Worklog Time Spent: 10m 
      Work Description: madrob commented on a change in pull request #4016:
URL: https://github.com/apache/hadoop/pull/4016#discussion_r813242150



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
##########
@@ -1378,7 +1378,7 @@ public long monotonicNow() {
     private final BlockingQueue<Runnable> queue;
 
     CommandProcessingThread(BPServiceActor actor) {
-      super("Command processor");
+      setName("Command processor-" + getId());

Review comment:
       Yes, exactly, @ayushtkn. All of the DN will have the same NN and then 
they will log the same thread name string.
   
   For adding DN address, I'm not sure which fields in DN are considered stable 
for this purpose. Maybe `setName("Command processor for " + 
dn.getDisplayName());` will work?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 731840)
    Time Spent: 1.5h  (was: 1h 20m)

> Multiple command processor threads have same name
> -------------------------------------------------
>
>                 Key: HDFS-16478
>                 URL: https://issues.apache.org/jira/browse/HDFS-16478
>             Project: Hadoop HDFS
>          Issue Type: Task
>          Components: datanode
>            Reporter: Mike Drob
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> When running an in-process MiniDFSCluster with multiple data nodes, the 
> command processor threads all share the same name, making them more difficult 
> to get debug and logging information from.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to