[ https://issues.apache.org/jira/browse/HDFS-15382?focusedWorklogId=733871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733871 ]
ASF GitHub Bot logged work on HDFS-15382: ----------------------------------------- Author: ASF GitHub Bot Created on: 28/Feb/22 14:13 Start Date: 28/Feb/22 14:13 Worklog Time Spent: 10m Work Description: MingXiangLi commented on a change in pull request #3941: URL: https://github.com/apache/hadoop/pull/3941#discussion_r815925168 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DiskBalancer.java ########## @@ -504,15 +503,13 @@ private void createWorkPlan(NodePlan plan) throws DiskBalancerException { Map<String, String> storageIDToVolBasePathMap = new HashMap<>(); FsDatasetSpi.FsVolumeReferences references; try { - try(AutoCloseableLock lock = this.dataset.acquireDatasetReadLock()) { Review comment: this method just get volumes snapshot so no need to acquire dataset lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 733871) Time Spent: 3h 50m (was: 3h 40m) > Split FsDatasetImpl from blockpool lock to blockpool volume lock > ----------------------------------------------------------------- > > Key: HDFS-15382 > URL: https://issues.apache.org/jira/browse/HDFS-15382 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Mingxiang Li > Assignee: Mingxiang Li > Priority: Major > Labels: pull-request-available > Attachments: HDFS-15382-sample.patch, image-2020-06-02-1.png, > image-2020-06-03-1.png > > Time Spent: 3h 50m > Remaining Estimate: 0h > > In HDFS-15180 we split lock to blockpool grain size.But when one volume is in > heavy load and will block other request which in same blockpool but different > volume.So we split lock to two leval to avoid this happend.And to improve > datanode performance. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org