[
https://issues.apache.org/jira/browse/HDFS-16495?focusedWorklogId=738465&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738465
]
ASF GitHub Bot logged work on HDFS-16495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 00:32
Start Date: 09/Mar/22 00:32
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #4054:
URL: https://github.com/apache/hadoop/pull/4054#issuecomment-1062430216
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 18s | | trunk passed |
| +1 :green_heart: | compile | 0m 40s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 35s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 23s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 41s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 41s | | trunk passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 53s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 19s | | trunk passed |
| +1 :green_heart: | shadedclient | 24m 8s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 32s | | the patch passed |
| +1 :green_heart: | compile | 0m 36s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 36s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 15s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
| hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 :green_heart: | mvnsite | 0m 32s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 31s | | the patch passed with JDK
Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 50s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 1m 26s |
[/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/artifact/out/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html)
| hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) |
| +1 :green_heart: | shadedclient | 23m 27s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| -1 :x: | unit | 50m 4s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt)
| hadoop-hdfs-rbf in the patch passed. |
| +1 :green_heart: | asflicense | 0m 43s | | The patch does not
generate ASF License warnings. |
| | | 147m 4s | | |
| Reason | Tests |
|-------:|:------|
| SpotBugs | module:hadoop-hdfs-project/hadoop-hdfs-rbf |
| | Possible null pointer dereference of null in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.addClientIpToCallerContext()
Dereferenced at RouterRpcClient.java:null in
org.apache.hadoop.hdfs.server.federation.router.RouterRpcClient.addClientIpToCallerContext()
Dereferenced at RouterRpcClient.java:[line 604] |
| Failed junit tests |
hadoop.fs.contract.router.TestRouterHDFSContractCreate |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractSeek |
| | hadoop.hdfs.server.federation.metrics.TestNameserviceRPCMetrics |
| | hadoop.fs.contract.router.TestRouterHDFSContractSetTimes |
| |
hadoop.hdfs.server.federation.router.TestRouterFederationRenamePermission |
| | hadoop.hdfs.server.federation.router.TestRouterMountTable |
| |
hadoop.hdfs.server.federation.router.TestRouterFederationRenameInKerberosEnv |
| | hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload |
| | hadoop.fs.contract.router.TestRouterHDFSContractConcatSecure |
| | hadoop.hdfs.server.federation.router.TestRouterWebHdfsMethods |
| | hadoop.hdfs.server.federation.router.TestRouterMultiRack |
| | hadoop.hdfs.server.federation.router.TestRouterQuota |
| | hadoop.fs.contract.router.TestRouterHDFSContractRootDirectorySecure |
| | hadoop.hdfs.server.federation.router.TestRouterNamenodeMonitoring |
| |
hadoop.hdfs.server.federation.router.TestRouterRpcStoragePolicySatisfier |
| | hadoop.hdfs.server.federation.router.TestRouterFederationRename |
| | hadoop.fs.contract.router.TestRouterHDFSContractAppend |
| | hadoop.fs.contract.router.TestRouterHDFSContractAppendSecure |
| | hadoop.fs.contract.router.TestRouterHDFSContractCreateSecure |
| | hadoop.hdfs.server.federation.fairness.TestRouterHandlersFairness |
| | hadoop.fs.contract.router.TestRouterHDFSContractOpen |
| | hadoop.hdfs.server.federation.router.TestRouterRPCClientRetries |
| | hadoop.fs.contract.router.TestRouterHDFSContractOpenSecure |
| | hadoop.fs.contract.router.TestRouterHDFSContractRootDirectory |
| | hadoop.hdfs.server.federation.router.TestRouterMissingFolderMulti |
| | hadoop.hdfs.server.federation.router.TestRouterAllResolver |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractMkdir |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractCreate |
| | hadoop.hdfs.server.federation.router.TestRouterFaultTolerant |
| | hadoop.fs.contract.router.TestRouterHDFSContractDeleteSecure |
| | hadoop.fs.contract.router.TestRouterHDFSContractGetFileStatusSecure |
| | hadoop.fs.contract.router.TestRouterHDFSContractGetFileStatus |
| | hadoop.hdfs.rbfbalance.TestMountTableProcedure |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractDelete |
| | hadoop.fs.contract.router.TestRouterHDFSContractRename |
| | hadoop.hdfs.server.federation.router.TestRouterTrash |
| | hadoop.fs.contract.router.TestRouterHDFSContractDelegationToken |
| | hadoop.hdfs.server.federation.router.TestRouterFsck |
| | hadoop.fs.contract.router.TestRouterHDFSContractRenameSecure |
| | hadoop.hdfs.server.federation.router.TestDisableNameservices |
| | hadoop.hdfs.server.federation.router.TestRouterAdmin |
| | hadoop.fs.contract.router.TestRouterHDFSContractSeek |
| | hadoop.fs.contract.router.TestRouterHDFSContractSeekSecure |
| | hadoop.fs.contract.router.TestRouterHDFSContractMkdir |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractRename |
| | hadoop.fs.contract.router.TestRouterHDFSContractConcat |
| | hadoop.fs.contract.router.TestRouterHDFSContractSetTimesSecure |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractRootDirectory |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractAppend |
| | hadoop.hdfs.server.federation.router.TestRouterNetworkTopologyServlet |
| | hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractConcat |
| | hadoop.hdfs.server.federation.router.TestSafeMode |
| | hadoop.fs.contract.router.TestRouterHDFSContractDelete |
| | hadoop.hdfs.server.federation.router.TestRouterRpcSingleNS |
| | hadoop.hdfs.server.federation.metrics.TestRouterClientMetrics |
| | hadoop.fs.contract.router.web.TestRouterWebHDFSContractOpen |
| | hadoop.fs.contract.router.TestRouterHDFSContractMkdirSecure |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4054 |
| JIRA Issue | HDFS-16495 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux a250790c75be 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5
11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e7c0c118a0fe28f9fe78e493f9b4d9e01454a975 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/testReport/ |
| Max. process+thread count | 3412 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-rbf U:
hadoop-hdfs-project/hadoop-hdfs-rbf |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4054/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 738465)
Time Spent: 20m (was: 10m)
> RBF should prepend the client ip rather than append it.
> -------------------------------------------------------
>
> Key: HDFS-16495
> URL: https://issues.apache.org/jira/browse/HDFS-16495
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the Routers append the client ip to the caller context if and only
> if it is not already set. This would allow the user to fake their ip by
> setting the caller context. Much better is to prepend it unconditionally.
> The NN must be able to trust the client ip from the caller context.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
