[ 
https://issues.apache.org/jira/browse/HDFS-16504?focusedWorklogId=742264&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742264
 ]

ASF GitHub Bot logged work on HDFS-16504:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/22 12:32
            Start Date: 16/Mar/22 12:32
    Worklog Time Spent: 10m 
      Work Description: Hexiaoqiao commented on a change in pull request #4068:
URL: https://github.com/apache/hadoop/pull/4068#discussion_r827955269



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
##########
@@ -4119,6 +4119,14 @@
     Mover, and StoragePolicySatisfier.
   </description>
 </property>
+<property>
+  <name>dfs.namenode.get-blocks.check.operation</name>
+  <value>true</value>
+  <description>
+    Whether enable checkOperation when call getBlocks.
+    It is enabled (true) by default.

Review comment:
       It almost look good to me. Just one nit, add "Set false to disable 
checkOperation and getBlocks for Balancer will route to Standby NameNode for HA 
mode setup." will be more readable for end user.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 742264)
    Time Spent: 50m  (was: 40m)

> add `dfs.namenode.get-blocks.check.operation` to enable or disable 
> checkOperation when NNs process getBlocks
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-16504
>                 URL: https://issues.apache.org/jira/browse/HDFS-16504
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer &amp; mover, namanode
>    Affects Versions: 3.4.0
>            Reporter: Max  Xie
>            Assignee: Max  Xie
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> HDFS-13183  add a nice feature that Standby NameNode can process getBlocks 
> request to reduce Active load.  Namenode must set  `dfs.ha.allow.stale.reads 
> = true` to enable this feature. However, if we  set `dfs.ha.allow.stale.reads 
> = true`, Standby Namenode will be able to  process all read requests, which 
> may lead to yarn jobs fail  because  Standby Namenode is stale . 
> Maybe we should add a config `dfs.namenode.get-blocks.check.operation=false` 
> for namenode to disable check operation  when namenode process getBlocks 
> request.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to