[ https://issues.apache.org/jira/browse/HDFS-16498?focusedWorklogId=748178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748178 ]
ASF GitHub Bot logged work on HDFS-16498: ----------------------------------------- Author: ASF GitHub Bot Created on: 26/Mar/22 09:56 Start Date: 26/Mar/22 09:56 Worklog Time Spent: 10m Work Description: tomscut commented on a change in pull request #4057: URL: https://github.com/apache/hadoop/pull/4057#discussion_r835745725 ########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java ########## @@ -2751,6 +2751,13 @@ public boolean checkBlockReportLease(BlockReportContext context, return true; } DatanodeDescriptor node = datanodeManager.getDatanode(nodeID); + if (node == null) { + final UnregisteredNodeException e = new UnregisteredNodeException(nodeID, null); + NameNode.stateChangeLog.error("BLOCK* NameSystem.getDatanode: " + "Data node " + nodeID + Review comment: > @tomscut you can remove this exception from here, considering it is being logged in the upper method. > > > Although it is DEBU level now, we could improve that to WARN, right? > > I think debug is also fine, this doesn't denote any problematic stuff, this can happen in normal scenario as well and the datanode will register subsequently Hi @ayushtkn, do you mean I just remove this log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 748178) Time Spent: 4h (was: 3h 50m) > Fix NPE for checkBlockReportLease > --------------------------------- > > Key: HDFS-16498 > URL: https://issues.apache.org/jira/browse/HDFS-16498 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: tomscut > Assignee: tomscut > Priority: Major > Labels: pull-request-available > Attachments: image-2022-03-09-20-35-22-028.png, screenshot-1.png > > Time Spent: 4h > Remaining Estimate: 0h > > During the restart of Namenode, a Datanode is not registered, but this > Datanode triggers FBR, which causes NPE. > !image-2022-03-09-20-35-22-028.png|width=871,height=158! -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org