[ 
https://issues.apache.org/jira/browse/HDFS-16522?focusedWorklogId=748323&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748323
 ]

ASF GitHub Bot logged work on HDFS-16522:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/22 12:58
            Start Date: 27/Mar/22 12:58
    Worklog Time Spent: 10m 
      Work Description: aajisaka commented on a change in pull request #4108:
URL: https://github.com/apache/hadoop/pull/4108#discussion_r835904003



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
##########
@@ -1648,14 +1668,29 @@ public synchronized void startDataNodes(Configuration 
conf, int numDataNodes,
       boolean setupHostsFile,
       boolean checkDataNodeAddrConfig,
       boolean checkDataNodeHostConfig,
-      Configuration[] dnConfOverlays) throws IOException {
+      Configuration[] dnConfOverlays,
+      int[] dnHttpPorts,
+      int[] dnIpcPorts) throws IOException {

Review comment:
       I think it is a safe change. This class is 
`@InterfaceAudience.LimitedPrivate({"HBase", "HDFS", "Hive", "MapReduce", 
"Pig"})`. I checked the source code of Hive, HBase, and Pig. The method 
signature is not used anywhere.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 748323)
    Time Spent: 50m  (was: 40m)

> Set Http and Ipc ports for Datanodes in MiniDFSCluster
> ------------------------------------------------------
>
>                 Key: HDFS-16522
>                 URL: https://issues.apache.org/jira/browse/HDFS-16522
>             Project: Hadoop HDFS
>          Issue Type: Task
>            Reporter: Viraj Jasani
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> We should provide options to set Http and Ipc ports for Datanodes in 
> MiniDFSCluster.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to